Open
Conversation
adpeyre
commented
Jun 8, 2022
adpeyre
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
vvasiloi
reviewed
Jun 10, 2022
vvasiloi
approved these changes
Jun 10, 2022
Author
|
Merge and release soon ? :) |
|
My colleagues might ask for a test, but let's find it out. @Zales0123 WDYT about this one? |
Contributor
|
Hello @adpeyre 🖖 Yes, covering it with tests would be needed. Not only unit tests (PHPSpec) but also functional (as we already have them introduced). Moreover, as we already have support for SymfonyMailer as well, we would need to add such a feature in this adapter too. But the feature proposal itself is nice 👌 Let me know if you need any help 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.